Make encodings abstract, add native_endian/big_endian methods #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottPJones
force-pushed
the
spj/encodings
branch
from
69220a7
to
003d02c
Compare
|
@quinnj You'd asked for a PR for this, do you want to go ahead and merge this? Thanks! |
quinnj
added a commit
that referenced
this pull request
Jun 16, 2015
Make encodings abstract, add native_endian/big_endian methods
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you do simply deal with the abstract
UTF16, instead of big-endian vs. little-endian variants (which only is an issue when you have to store them into bytes).For example, next will return a Char, not a sequence of bytes, so you can write a function that handles UTF16 encoding, and pass it something that is UTF16OE, and it will handle the byte-swapping for you.