Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release #307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Patch release #307

wants to merge 1 commit into from

Conversation

0x0f0f0f
Copy link

Needed after #302 (comment) - it's an important security
fix to use parse instead of read - if exposed in packages implementing public HTTP APIs it allows people
to read arbitrary files on the host machine FS

@hhaensel
Copy link

hhaensel commented Feb 17, 2025

Moreover, parsing time gets better if you process many small messages. On my Windows system parsing is more than a factor of 100 faster in the second benchmark of #294 (comment) from 6ms down to 45µs.

@hhaensel
Copy link

BTW, shouldn't there also be a parse!(str::AbstractString, x::T; kw...) and parsefile!(str::AbstractString, x::T; kw...) for incremental structure parsing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants