This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
Propogate missings with arithmatic #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This github repository is deprecated; please make PRs against the |
|
Yeah that's what I thought. This is what the remote was when I did |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue: JuliaLang/julia#28570 points out that arithmetic with dates and missing values throws an error. Instead, dates should behave like numbers in this instance, propagating missing values.
This PR adds 4 methods for operations with missing and
TimeType.+,-, and both orders for each.However it is likely this adds too much behavior, as it seems not all
TimeTypesubtypes support+(you can't add years). I would appreciate some guidance for more specific methods to add.