Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No workspace lints #1955

Merged
merged 2 commits into from
Aug 4, 2024
Merged

No workspace lints #1955

merged 2 commits into from
Aug 4, 2024

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Aug 3, 2024

After publishing quinn-proto 0.11.4, building downstream crates (even quinn itself) fails with:

error: failed to download `quinn-proto v0.11.4`

Caused by:
  unable to get packages from source

Caused by:
  failed to parse manifest at `/home/ralith/.cargo/registry/src/index.crates.io-6f17d22bba15001f/quinn-proto-0.11.4/Cargo.toml`

Caused by:
  error inheriting `lints` from workspace root manifest's `workspace.lints`

Caused by:
  failed to find a workspace root

This reproduces on cargo nightly, 1.80, and 1.79. quinn-proto 0.11.4 has been yanked.

Ralith added 2 commits August 3, 2024 16:03
This seems to break publishing on crates.io.
@Ralith
Copy link
Collaborator Author

Ralith commented Aug 3, 2024

If you're affected by this, cargo update will roll you back to the working 0.11.3 due to the yank.

@djc djc added this pull request to the merge queue Aug 4, 2024
@djc
Copy link
Member

djc commented Aug 4, 2024

Pinged the Cargo team about this on Zulip.

Merged via the queue into main with commit 91b5a56 Aug 4, 2024
8 checks passed
@djc djc deleted the no-workspace-lints branch August 4, 2024 06:51
@weihanglo
Copy link

Some versions of 1.79-beta and 1.80-nightly are indeed broken. @Ralith could you share which toolchain version (cargo -vV for every toolchain on your machine) you used when publishing quinn-proto? We need to make sure if it has been fixed or is a new regression. Thank you.

@djc
Copy link
Member

djc commented Aug 4, 2024

(It looks like an 1.80.1 is going out soon so might be interesting if we can identify this soonish.)

@weihanglo
Copy link

Just note that the upcoming 1.80.1 change in Cargo (rust-lang/cargo#14325) has nothing to do with this issue. It was rust-lang/cargo#13843 and fixed by rust-lang/cargo#13852 before any stable releases.

@Ralith
Copy link
Collaborator Author

Ralith commented Aug 4, 2024

I probably have tens if not hundreds of Rust toolchains on my machine, and went through several investigating this, but I think the original publish operation was with:

> cargo -vV
cargo 1.80.0-nightly (431db31d0 2024-05-28)
release: 1.80.0-nightly
commit-hash: 431db31d0dbeda320caf8ef8535ea48eb3093407
commit-date: 2024-05-28
host: x86_64-unknown-linux-gnu
libgit2: 1.7.2 (sys:0.18.3 vendored)
libcurl: 8.6.0-DEV (sys:0.4.72+curl-8.6.0 vendored ssl:OpenSSL/1.1.1w)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: NixOS 23.11.0 [64-bit]

It was definitely a 1.80.0-nightly. I suppose I should take care to publish with stable cargo versions in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants