CMakeLists.txt: fixes for various toolchains #22
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I was going to add libcorrect as a selectable package in buildroot, but I ran into some issues when I ran it against buildroot's tests (which compiles the package using a variety of toolchains with different capabilities/architectures). To get libcorrect to compile correctly for as many of the toolchains as I could, I did the following:
support this option and it is not necessary.
allows toolchains lacking C++ support to build the library.
removing dependency on C++.
The one I'm most unsure about is the removal of -march=native. I don't know why the Debug build would need to specify that, and with my builds it seemed to be fine without. But maybe there's something I'm not aware of.