Add clarification for PATHS_BLOCKED frame. #463
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirjak
reviewed
Nov 4, 2024
huitema
approved these changes
Nov 5, 2024
mirjak
reviewed
Nov 5, 2024
Yanmei-Liu
changed the title
qdeconinck
approved these changes
Nov 5, 2024
Co-authored-by: Quentin De Coninck <[email protected]>
…o dev/fix-461 Conflicts: draft-ietf-quic-multipath.md
mirjak
approved these changes
Nov 5, 2024
|
Is it PATHS_BLOCKED or PATH_BLOCKED? The text in the PR doesn't match the text immediately preceding it. |
mirjak
changed the title
draft-ietf-quic-multipath.md
Outdated
| @@ -1346,7 +1346,11 @@ MAX_PATH_ID frames that do not increase the path limit MUST be ignored. | |||
|
|
|||
| A sender SHOULD send a PATHS_BLOCKED frame (type=0x15228c0d) when | |||
| it wishes to open a path but is unable to do so due to the maximum path identifier | |||
| limit set by its peer; | |||
| limit set by its peer. | |||
| Note that PATH_BLOCKED frame is informational. Sending a PATH_BLOCKED frame does not | |||
There was a problem hiding this comment.
These should both say PATHS_BLOCKED rather than PATH_BLOCKED
There was a problem hiding this comment.
Nice catch! Updated.
Yanmei-Liu
commented
Nov 12, 2024
gloinul
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #461.
Generally the PATH_BLOCKED frame is informational and doesn't change the state of the peer.