Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some clippys, format #1144

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Resolve some clippys, format #1144

merged 4 commits into from
Aug 25, 2021

Conversation

sigaloid
Copy link
Contributor

Lots of f32->f64 comparisons need to be resolved as well, an error margin should be determined for comparison.

Passes tests

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #1144 (047afcc) into main (1a45b03) will increase coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
+ Coverage   89.49%   89.51%   +0.02%     
==========================================
  Files         203      203              
  Lines       20251    20243       -8     
==========================================
- Hits        18124    18121       -3     
+ Misses       2127     2122       -5     
Impacted Files Coverage Δ
src/functional_test.rs 0.00% <0.00%> (ø)
src/core/index.rs 87.53% <100.00%> (ø)
src/fastfield/serializer/mod.rs 71.23% <100.00%> (-0.39%) ⬇️
src/indexer/merger.rs 89.65% <100.00%> (+0.08%) ⬆️
src/indexer/merger_sorted_index_test.rs 100.00% <100.00%> (ø)
src/postings/block_segment_postings.rs 94.56% <100.00%> (ø)
src/postings/serializer.rs 89.39% <100.00%> (-0.06%) ⬇️
src/query/automaton_weight.rs 91.02% <100.00%> (-0.23%) ⬇️
src/query/boolean_query/mod.rs 100.00% <100.00%> (ø)
src/schema/mod.rs 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a45b03...047afcc. Read the comment docs.

@fulmicoton fulmicoton merged commit 096ce74 into quickwit-oss:main Aug 25, 2021
This was referenced Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants