Replaced RawDocument by OwnedBytes #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
owned-bytes-instead-of-rawdoc
branch
from
a125e74
to
cdc436c
Compare
fulmicoton
force-pushed
the
owned-bytes-instead-of-rawdoc
branch
from
cdc436c
to
913850b
Compare
PSeitz
reviewed
May 18, 2021
This was referenced Feb 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes RawDocument and uses OwnedBytes instead.
OwnedBytes is a self referring struct that offers a slice of data (&[u8]) and its ownership.
It is similar in many ways to RawDocument.
It implements Read.