Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return FastFieldReader concrete Type #1084

Closed
evanxg852000 opened this issue Jun 16, 2021 · 0 comments
Closed

Return FastFieldReader concrete Type #1084

evanxg852000 opened this issue Jun 16, 2021 · 0 comments
Assignees
@PSeitz
Labels
enhancement

Comments

@evanxg852000
Copy link
Collaborator

We would like to store and pass it around an instance of FastFieldReader.
Currently not all methods of tantivy::fastfield::readers::FastFieldReaders return a concrete type. Some return the opaque type
impl FastFieldReader<T> see.
Unfortunately FastFieldReader is not object safe. It would be nice to have all methods return the concrete type DynamicFastFieldReader<T>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSeitz PSeitz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix open bytes index quickwit-oss/tantivy
aggregation PSeitz/tantivy
3 participants
@evanxg852000 @fmassot @PSeitz