Add pre-init ICs#883
Closed
bnoordhuis wants to merge 1 commit into
Closed
Conversation
Defer creating the inline cache once, to avoid unprofitable busywork for JS code that only executes once. It's at best a qualified success. It succeeds at keeping the memory and CPU footprint of execute-once code down but it slows down the babel benchmark from the web-tooling-benchmark suite by 500% because that benchmark is all about property access on tree structures. Other benchmarks from the suite are unaffected, neither faster or slower, with the possible exception of the terser benchmark, which is a few percent slower for the same reason as the babel one, only much less pronounced.
Contributor
Author
|
Closing since we're going forward with #884. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer creating the inline cache once, to avoid unprofitable busywork for JS code that only executes once.
It's at best a qualified success. It succeeds at keeping the memory and CPU footprint of execute-once code down but it slows down the babel benchmark from the web-tooling-benchmark suite by 500% because that benchmark is all about property access on tree structures.
Other benchmarks from the suite are unaffected, neither faster or slower, with the possible exception of the terser benchmark, which is a few percent slower for the same reason as the babel one, only much less pronounced.
Refs: #876
Opened as a draft as a discussion starter because it probably shouldn't land as-is.