Port closure optimizations #1313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
force-pushed
the
refactor-closures
branch
from
c008353 to
4929037
Compare
bnoordhuis
approved these changes
Jan 9, 2026
| uint16_t var_count; | ||
| uint16_t defined_arg_count; /* for length function property */ | ||
| uint16_t stack_size; /* maximum stack size */ | ||
| uint16_t var_ref_count; /* number of local variable references */ |
Contributor
There was a problem hiding this comment.
This field creates a 6 byte padding hole on 64 bits architectures because of the alignment requirement of the next field. Can maybe be eliminated with some reshuffling.
Contributor
Author
There was a problem hiding this comment.
I did some AI assisted suffling of fields :-) Can you PTAL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: bellard/quickjs@ae7219b