Skip to content

Improve error handling in Promise.withResolvers #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 1 commit into from
Sep 29, 2025
Merged

Improve error handling in Promise.withResolvers #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions quickjs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50748,16 +50748,29 @@ static JSValue js_promise_withResolvers(JSContext *ctx, JSValueConst this_val,
if (JS_IsException(result_promise))
return JS_EXCEPTION;
obj = JS_NewObject(ctx);
if (JS_IsException(obj)) {
JS_FreeValue(ctx, resolving_funcs[0]);
JS_FreeValue(ctx, resolving_funcs[1]);
JS_FreeValue(ctx, result_promise);
return JS_EXCEPTION;
if (JS_IsException(obj))
goto exception;
if (JS_DefinePropertyValue(ctx, obj, JS_ATOM_promise, result_promise,
JS_PROP_C_W_E) < 0) {
goto exception;
}
result_promise = JS_UNDEFINED;
if (JS_DefinePropertyValue(ctx, obj, JS_ATOM_resolve, resolving_funcs[0],
JS_PROP_C_W_E) < 0) {
goto exception;
}
resolving_funcs[0] = JS_UNDEFINED;
if (JS_DefinePropertyValue(ctx, obj, JS_ATOM_reject, resolving_funcs[1],
JS_PROP_C_W_E) < 0) {
goto exception;
}
JS_DefinePropertyValue(ctx, obj, JS_ATOM_promise, result_promise, JS_PROP_C_W_E);
JS_DefinePropertyValue(ctx, obj, JS_ATOM_resolve, resolving_funcs[0], JS_PROP_C_W_E);
JS_DefinePropertyValue(ctx, obj, JS_ATOM_reject, resolving_funcs[1], JS_PROP_C_W_E);
return obj;
exception:
JS_FreeValue(ctx, resolving_funcs[0]);
JS_FreeValue(ctx, resolving_funcs[1]);
JS_FreeValue(ctx, result_promise);
JS_FreeValue(ctx, obj);
return JS_EXCEPTION;
}

static JSValue js_promise_try(JSContext *ctx, JSValueConst this_val,
Expand Down
Loading