Skip to content

Simplify a number of JS_IsFoo() functions #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 1 commit into from
Aug 4, 2025
Merged

Simplify a number of JS_IsFoo() functions #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 8 additions & 26 deletions quickjs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10237,60 +10237,42 @@ bool JS_SetConstructorBit(JSContext *ctx, JSValueConst func_obj, bool val)

bool JS_IsRegExp(JSValueConst val)
{
if (JS_VALUE_GET_TAG(val) != JS_TAG_OBJECT)
return false;
return JS_VALUE_GET_OBJ(val)->class_id == JS_CLASS_REGEXP;
return JS_CLASS_REGEXP == JS_GetClassID(val);
}

bool JS_IsMap(JSValueConst val)
{
if (JS_VALUE_GET_TAG(val) != JS_TAG_OBJECT)
return false;
return JS_VALUE_GET_OBJ(val)->class_id == JS_CLASS_MAP;
return JS_CLASS_MAP == JS_GetClassID(val);
}

bool JS_IsSet(JSValueConst val)
{
if (JS_VALUE_GET_TAG(val) != JS_TAG_OBJECT)
return false;
return JS_VALUE_GET_OBJ(val)->class_id == JS_CLASS_SET;
return JS_CLASS_SET == JS_GetClassID(val);
}

bool JS_IsWeakRef(JSValueConst val)
{
if (JS_VALUE_GET_TAG(val) != JS_TAG_OBJECT)
return false;
return JS_VALUE_GET_OBJ(val)->class_id == JS_CLASS_WEAK_REF;
return JS_CLASS_WEAK_REF == JS_GetClassID(val);
}

bool JS_IsWeakSet(JSValueConst val)
{
if (JS_VALUE_GET_TAG(val) != JS_TAG_OBJECT)
return false;
return JS_VALUE_GET_OBJ(val)->class_id == JS_CLASS_WEAKSET;
return JS_CLASS_WEAKSET == JS_GetClassID(val);
}

bool JS_IsWeakMap(JSValueConst val)
{
if (JS_VALUE_GET_TAG(val) != JS_TAG_OBJECT)
return false;
return JS_VALUE_GET_OBJ(val)->class_id == JS_CLASS_WEAKMAP;
return JS_CLASS_WEAKMAP == JS_GetClassID(val);
}

bool JS_IsDataView(JSValueConst val)
{
if (JS_VALUE_GET_TAG(val) != JS_TAG_OBJECT)
return false;
return JS_VALUE_GET_OBJ(val)->class_id == JS_CLASS_DATAVIEW;
return JS_CLASS_DATAVIEW == JS_GetClassID(val);
}

bool JS_IsError(JSContext *ctx, JSValueConst val)
{
JSObject *p;
if (JS_VALUE_GET_TAG(val) != JS_TAG_OBJECT)
return false;
p = JS_VALUE_GET_OBJ(val);
return (p->class_id == JS_CLASS_ERROR);
return JS_CLASS_ERROR == JS_GetClassID(val);
}

/* used to avoid catching interrupt exceptions */
Expand Down
Loading