fix: support Apple Clang 13

Fix issues when compiling with Apple Clang 13.1.6 for macOS: * add explicit casts * add explicit [[noreturn]] attributes * add missing #include * disable spurious warnings * stop using removed warning flag (-Wfallback)
quick-lint · Jul 1, 2022 · df34a98 · df34a98
1 parent c36a92a
commit df34a98
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 5 deletions.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
diff --git a/benchmark/benchmark-lsp/process.cpp b/benchmark/benchmark-lsp/process.cpp
@@ -6,6 +6,7 @@
 #include <cstdlib>
 #include <cstring>
 #include <quick-lint-js/narrow-cast.h>
+#include <quick-lint-js/process.h>
 #include <sys/wait.h>
 #include <unistd.h>
 

diff --git a/plugin/vscode/quick-lint-js-vscode-node.cpp b/plugin/vscode/quick-lint-js-vscode-node.cpp
@@ -901,7 +901,7 @@ class qljs_workspace : public ::Napi::ObjectWrap<qljs_workspace> {
       return this->stop_pipe_.reader.ref();
     }
 
-    void append(string8_view) { QLJS_UNREACHABLE(); }
+    [[noreturn]] void append(string8_view) { QLJS_UNREACHABLE(); }
 
 #if QLJS_HAVE_KQUEUE || QLJS_HAVE_POLL
     std::optional<posix_fd_file_ref> get_pipe_write_fd() {
@@ -910,9 +910,13 @@ class qljs_workspace : public ::Napi::ObjectWrap<qljs_workspace> {
 #endif
 
 #if QLJS_HAVE_KQUEUE
-    void on_pipe_write_event(const struct ::kevent&) { QLJS_UNREACHABLE(); }
+    [[noreturn]] void on_pipe_write_event(const struct ::kevent&) {
+      QLJS_UNREACHABLE();
+    }
 #elif QLJS_HAVE_POLL
-    void on_pipe_write_event(const ::pollfd&) { QLJS_UNREACHABLE(); }
+    [[noreturn]] void on_pipe_write_event(const ::pollfd&) {
+      QLJS_UNREACHABLE();
+    }
 #endif
 
     void filesystem_changed() {

diff --git a/plugin/vscode/quick-lint-js/vscode-tracer.h b/plugin/vscode/quick-lint-js/vscode-tracer.h
@@ -134,7 +134,8 @@ class vscode_tracer {
       std::vector<trace_vscode_document_change> traced_changes(
           changes.Length());
       for (std::size_t i = 0; i < traced_changes.size(); ++i) {
-        ::Napi::Object change = changes.Get(i).As<::Napi::Object>();
+        ::Napi::Object change =
+            changes.Get(narrow_cast<std::uint32_t>(i)).As<::Napi::Object>();
         ::Napi::Object range = change.Get("range").As<::Napi::Object>();
         ::Napi::Object start = range.Get("start").As<::Napi::Object>();
         ::Napi::Object end = range.Get("end").As<::Napi::Object>();

diff --git a/src/lex.cpp b/src/lex.cpp
@@ -1801,6 +1801,7 @@ QLJS_WARNING_POP
 
 QLJS_WARNING_PUSH
 QLJS_WARNING_IGNORE_CLANG("-Wunknown-attributes")
+QLJS_WARNING_IGNORE_CLANG("-Wunreachable-code")
 QLJS_WARNING_IGNORE_GCC("-Wattributes")
 void lexer::skip_whitespace() {
   const char8* input = this->input_;

diff --git a/test/test-simd.cpp b/test/test-simd.cpp
@@ -8,6 +8,7 @@
 #include <quick-lint-js/char8.h>
 #include <quick-lint-js/have.h>
 #include <quick-lint-js/simd.h>
+#include <quick-lint-js/warning.h>
 
 #if QLJS_HAVE_ARM_NEON
 #include <arm_neon.h>
@@ -17,6 +18,8 @@
 #include <emmintrin.h>
 #endif
 
+QLJS_WARNING_IGNORE_CLANG("-Wconditional-uninitialized")
+
 namespace quick_lint_js {
 namespace {
 #if QLJS_HAVE_X86_SSE2