-
Notifications
You must be signed in to change notification settings - Fork 32
feat(web-console): import Parquet files #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for importing Parquet files to the web console, extending the existing CSV import functionality. The implementation introduces a parallel import workflow for Parquet files with a unified interface that allows users to choose between CSV and Parquet import modes.
Key changes:
- Added Parquet file import functionality with drag-and-drop support and upload queue management
- Unified the import interface with a dropdown menu to select between CSV and Parquet import types
- Refactored existing CSV import components to share common functionality with the new Parquet import system
Reviewed Changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-console/webpack.config.js | Added API proxy configuration for Parquet upload endpoints |
| packages/web-console/src/utils/questdb/types.ts | Defined type definitions for Parquet upload results and unified file upload types |
| packages/web-console/src/utils/questdb/client.ts | Implemented uploadParquetFiles method for handling Parquet file uploads |
| packages/web-console/src/store/Console/types.ts | Added import type state management for switching between CSV and Parquet modes |
| packages/web-console/src/scenes/Import/index.tsx | Created unified import component that renders CSV or Parquet import based on selected type |
| packages/web-console/src/scenes/Import/ImportParquet/ | New Parquet import components including file list, upload logic, and rename dialog |
| packages/web-console/src/scenes/Import/ImportCSVFiles/ | Refactored CSV import to use shared components and updated type definitions |
| packages/web-console/src/scenes/Import/FileStatus.tsx | Unified file status component supporting both CSV and Parquet file types |
| packages/web-console/src/scenes/Import/Dropbox*.tsx | Shared dropbox components for file drag-and-drop functionality |
| packages/web-console/src/scenes/Console/index.tsx | Updated console UI to include import type dropdown menu |
Comments suppressed due to low confidence (1)
packages/web-console/src/scenes/Import/FileStatus.tsx:1
- Inline styles should be extracted to styled components or use theme colors instead of hardcoded color values. This ensures consistency with the design system and makes maintenance easier.
import React, { useState } from "react"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/web-console/src/scenes/Import/ImportCSVFiles/index.tsx
Outdated
Show resolved
Hide resolved
packages/web-console/src/scenes/Import/ImportCSVFiles/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 32 out of 34 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
packages/web-console/src/scenes/Import/ImportParquet/rename-file-dialog.tsx:1
- Inline styles are duplicated across multiple code elements. Extract the common styling into a styled component or CSS class to improve maintainability.
import React from "react"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/web-console/src/scenes/Import/ImportCSVFiles/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 32 out of 34 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.