WIP DataValueArray #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of levels is supposed to be respected now, and replaces the order/ordered arguments when not provided. This wasn't tested and broken.
Also add tests for these.
* Updates for 0.5 and get tests passing * Do the 0.5 updates in a compat friendly way * Add 0.4 compat for the sum_pairwise_blocksize removal from Base * Quick update to constructors test
Reflects better the features of the package, and consistent with e.g. NullableArrays.
…(::CategoricalArray) The former didn't work, and made the second fail.
These are no longer needed now that constructors special-case Nullable.
Needed by vcat() for DataFrames. The promotion goes back to the wrapped type, since converting to a CategoricalValue would require modifying the pool or creating a new one, which does not make much sense. similar() will take care of going back to CategoricalValue when called on CategoricalArray.
This describes better the contents of the field, and is consistent with PooledDataArray's structure. Fixes #1.
Useful for generic definitions in DataFrames.
It is only an abstract type with NominalPool and OrdinalPool subtypes.
Somewhat more natural and consistent with PooledDataArrays.
Needed to build a CategoricalArray with a pre-built pool in DataFrames.
This is similar to what NullableArrays provides, and is used in DataFrames when reading CSV files.
…field points to. Implements #112
Add a ref field to NullableArray
Add badges and fix a couple typos
Add precompilation
Correct the REQUIRE file for julia 0.4
* Fix primitives test on 0.5 Thrown error has changed. * Use checkindex() on Julia 0.5 Old checkbounds() methods are deprecated and indexing test was failing.
Transition to broadcast interface in JuliaLang/julia@522547b
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.