E2e test scaffolding #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleesc
force-pushed
the
e2e-test-scaffolding
branch
5 times, most recently
from
9271c2c to
de93b66
Compare
jzelinskie
suggested changes
Sep 30, 2019
controllers/event_filters.go
Outdated
| @@ -0,0 +1,64 @@ | |||
| package controllers | |||
There was a problem hiding this comment.
Isn't this the logic from #6? I think it needs to be removed from this PR.
|
Please rebase this on master and remove the event filter stuff from #6 |
kleesc
force-pushed
the
e2e-test-scaffolding
branch
from
de93b66 to
85dfd70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.