Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin): compatible with vite 3.0 changes #13999

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

kalvenschraut
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

fixes #13955
Changed peer dependency to allow vite 3.0.0 and 2.0.0 versions

Also noticed that if you have typescript in your script vue SFC the auto imports of quasar components broke with any version past the @vitejs/plugin-vue 3.0.0 alpha. Found this PR which I believe caused the auto imports to break. Have to also look for script along with template now since its not inlined together anymore. Updated regex to look for both.

@rstoenescu rstoenescu self-requested a review July 25, 2022 18:31
@rstoenescu rstoenescu merged commit 7bc200c into quasarframework:dev Jul 26, 2022
@rstoenescu
Copy link
Member

Thanks for contributing!

@kalvenschraut kalvenschraut deleted the vite-3.0.0-compatible branch July 26, 2022 20:16
@LiamKarlMitchell
Copy link

Is this able to be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm add -D @quasar/vite-plugin [email protected]
3 participants