fix(app-webpack): Cordova & Android -> usesCleartextTraffic attribute…

… is always true in the AndroidManifest.xml file #17219

app-webpack/lib/cordova/android-cleartext.js

@@ -0,0 +1,36 @@
+const fs = require('fs')
+const appPaths = require('../app-paths')
+
+module.exports = function fixAndroidCleartext (action) {
+  const androidManifestPath = appPaths.resolve.cordova(
+    'platforms/android/app/src/main/AndroidManifest.xml'
+  )
+
+  if (fs.existsSync(androidManifestPath) === false) return
+
+  let androidManifest = fs.readFileSync(androidManifestPath, 'utf8')
+  const hasCleartext = androidManifest.indexOf('android:usesCleartextTraffic="true"') !== -1
+
+  if (action === 'add') {
+    if (hasCleartext === false) {
+      androidManifest = androidManifest.replace(
+        '<application',
+        '<application\n        android:usesCleartextTraffic="true"'
+      )
+
+      fs.writeFileSync(androidManifestPath, androidManifest, 'utf-8')
+    }
+
+    return
+  }
+
+  // else remove it
+  if (hasCleartext === true) {
+    androidManifest = androidManifest.replace(
+      '        android:usesCleartextTraffic="true"\n',
+      ''
+    )
+
+    fs.writeFileSync(androidManifestPath, androidManifest, 'utf-8')
+  }
+}

app-webpack/lib/cordova/index.js

@@ -42,7 +42,7 @@ class CordovaRunner {
     this.target = ctx.targetName
 
     if (this.target === 'android') {
-      require('../helpers/fix-android-cleartext')('cordova')
+      require('./android-cleartext')(this.ctx.dev ? 'add' : 'remove')
     }
   }