New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implementing noqa directives #855

Merged

benfdking merged 1 commit into main from implementing_noqa_director

Oct 8, 2024

Collaborator

benfdking commented Oct 8, 2024

No description provided.

benfdking force-pushed the implementing_noqa_director branch from dafbc30 to 3958b2e Compare

October 8, 2024 20:55

benfdking mentioned this pull request

[Rule] LT01 - spacing #830

Closed

github-actions bot commented Oct 8, 2024

Benchmark for `473954f`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	40.8±0.52µs	40.4±0.40µs	-0.98%
fix_complex_query	11.9±0.11ms	12.1±0.14ms	+1.68%
parse_complex_query	2.9±0.04µs	2.8±0.04µs	-3.45%
parse_expression_recursion	5.1±0.09µs	5.2±0.04µs	+1.96%
parse_simple_query	833.1±29.70ns	821.5±16.35ns	-1.39%

github-actions bot commented Oct 8, 2024

Benchmark for `5a96305`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	41.2±1.20µs	40.4±0.43µs	-1.94%
fix_complex_query	11.8±0.11ms	12.2±0.11ms	+3.39%
parse_complex_query	2.9±0.05µs	2.9±0.04µs	0.00%
parse_expression_recursion	5.1±0.06µs	5.1±0.04µs	0.00%
parse_simple_query	858.4±9.41ns	847.2±15.38ns	-1.30%

benfdking force-pushed the implementing_noqa_director branch 2 times, most recently from a98effa to 531daa6 Compare

October 8, 2024 21:30


          feat: implementing basic noqa

0f530f0

# Conflicts:
#	crates/lib/src/core/linter/core.rs

benfdking force-pushed the implementing_noqa_director branch from 531daa6 to 0f530f0 Compare

October 8, 2024 21:32

github-actions bot commented Oct 8, 2024

Benchmark for `e88e15e`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	41.0±1.09µs	40.8±0.32µs	-0.49%
fix_complex_query	11.8±0.07ms	11.8±0.09ms	0.00%
parse_complex_query	2.8±0.08µs	2.9±0.03µs	+3.57%
parse_expression_recursion	5.1±0.06µs	5.0±0.04µs	-1.96%
parse_simple_query	823.2±12.61ns	833.1±13.87ns	+1.20%

benfdking merged commit a782011 into main

15 checks passed

benfdking deleted the implementing_noqa_director branch

October 8, 2024 21:42

github-actions bot commented Oct 8, 2024

Benchmark for `18701a7`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	41.0±0.59µs	41.2±0.47µs	+0.49%
fix_complex_query	11.8±0.12ms	11.9±0.16ms	+0.85%
parse_complex_query	2.9±0.04µs	2.9±0.04µs	0.00%
parse_expression_recursion	5.1±0.03µs	5.1±0.06µs	0.00%
parse_simple_query	826.6±8.00ns	837.5±23.28ns	+1.32%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet