-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add IServiceProvider overloads #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
I believe the ask was to have |
|
As you say, it doesn't completely solve the problem, but it does partially solve it and enables many use cases that were not possible until now. I first tried to do what was requested, but as you said it required a major refactoring and I found it very complex. I'm sure users will at least appreciate having these overloads. In my case it unlocks many uses cases. Now, for example, if I want to add cron, I can read the expression with IOptions from a JSON file or an env. |
lahma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for this specific use case, thank you for your contribution!
|
@bdovaz could you also create a PR against main the ensure these will be available there too? |



Partially fixes #1617
Add factories with
IServiceProviderto all extension methods: AddJob, AddTrigger, ScheduleJob, and AddCalendar.