-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 21 virtual thread support #1093
Conversation
@melloware who would give us another approval? |
cc @jhouserizer I will admit it doesn't look like there has been much activity here which is dissapointing and last public release was 2019? |
There were releases made earlier in the year (with dozens of changes) as RCs awaiting feedback. Official non-RC releases will be made in the next week or two. It's true that current efforts on the project are sporadic. This contribution is interesting and will be looked at . |
…sts is the question really. Signed-off-by: noga <[email protected]>
Signed-off-by: noga <[email protected]>
…ils in JDK-21. Signed-off-by: noga <[email protected]>
Added the DCO fix as expected by the doc. |
There are no releases, no feedback on PRs nor on issues, no replies on the user's list, and the developer's forum link points to nowhere. Quartz is not only poorly maintained, but it is not maintained at all... |
@@ -0,0 +1,124 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a code format should be run on these so that the formatting is consistent. For example some methods have a space before open bracket some don't.
public void foo1() {
// ...
}
and
public void foo2(){
// ...
}
|
||
tasks.withType(Test).configureEach { | ||
if ( JDK_PATH != null ) { | ||
println("External Java home '${JDK_PATH}' spefified for tests!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are not necessary, also typo here. Changes to build.gradle should be reverted.
try{ | ||
return callable.call(); | ||
}catch (Throwable ex){ | ||
log.warn( message + ex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is better
log.warn("{}{}", message, ex);
Unfortunately, due to the change of ownership of this project, the terms of contribution have been updated, and this PR will need to be re-created, agreeing to the new terms. |
In submitting this contribution, I agree to the current Software AG contributor agreement as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md
This PR...
How to Run
Changes
Adds a
SimpleVirtualThreadPool
to do a virtual thread support.Checklist
git commit -s
on my commits.(If you're not using command-line, you can use a browser extension )
Known Issues
In java 21 - the following tests fail: