Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace polyfill.io #8969

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 4, 2024

Description

polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.

The original creator of the polyfill.io has voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, AlistGo/alist#6100), rendering the polyfill.io service extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances of polyfill.io service.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog

@cderv
Copy link
Collaborator

cderv commented Mar 4, 2024

Thanks !

FWIW Pandoc also just did the change in its template: jgm/pandoc@5877ec5 based on initial PR jgm/pandoc#9537 also by you @SukkaW

We'll get then eventually at next Pandoc release update in Quarto, but we could probably already import that change in our pre-release. Anything against this @cscheid ?

@cscheid
Copy link
Collaborator

cscheid commented Mar 4, 2024

No, this looks good.

@cscheid cscheid merged commit 27c03ce into quarto-dev:main Mar 4, 2024
47 checks passed
robe2037 added a commit to ipums/dhs-research-hub that referenced this pull request Jun 26, 2024
Avoids using polyfill.io see quarto-dev/quarto-cli#8969
cscheid added a commit that referenced this pull request Jun 26, 2024
@cscheid cscheid added the security Issues to be reviewed by Posit's security team label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Issues to be reviewed by Posit's security team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants