Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct image file name to resolve broken image #44531

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Nov 15, 2024

https://quarkus.io/version/main/guides/extension-maturity-matrix has a image alt text, because on the last version of the image, a hyphen got replaced with an underscore.

This is a fix to #42446.

@holly-cummins holly-cummins changed the title Correct image file name Correct image file name to resolve broken image Nov 15, 2024
@gsmet
Copy link
Member

gsmet commented Nov 15, 2024

In which versions do we plan to push this content?

Copy link

github-actions bot commented Nov 15, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Nov 15, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1e8cad0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@holly-cummins
Copy link
Contributor Author

In which versions do we plan to push this content?

I don't have strong feelings. It's been long enough since the LTS we probably don't need to push it back that far. Getting it and #42446 into 3.17 might be nice so it's searchable on the default docs view, but I have a feeling it will mostly be consumed by manual sharing of the link, at least in the short term.

@gastaldi gastaldi merged commit 69c0b8e into quarkusio:main Nov 15, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 15, 2024
@gsmet
Copy link
Member

gsmet commented Nov 15, 2024

OK, I will push both PRs to 3.16 and 3.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants