-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Timestamp not being set for otel log signals #44507
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
Thanks for the contribution! Please rebase the PR onto |
|
I just rebased it with the GitHub UI. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, but let's let @brunobat decide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it needs to be current time.
...try/runtime/src/main/java/io/quarkus/opentelemetry/runtime/logs/OpenTelemetryLogHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check comments above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The history is problematic, I will fix it. |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
Thanks for the fix! It will be included in the next 3.16. |
When using the otel logging, the log messages where displayed wrong in the Elastic Stack because the Timestamp was not set to the Log Signal. The Reason for this is that APM-Server is using the Timestamp and not the ObservedTimestamp for displaying the Message. For this reason they where display in the year 1970 in Elastic Stack.