Log in smallrye-jwt and oauth2 extensions when no bearer access token is available #44505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Nov 14, 2024
sberyozkin
force-pushed
the
log_no_credentials_available
branch
from
eb544d9
to
542da9d
Compare
sberyozkin
force-pushed
the
log_no_credentials_available
branch
from
542da9d
to
7e3f237
Compare
|
Sorry @gastaldi I just noticed the elytron oauth2 extension does not have the same message, so I copied it there as well, sorry for the noise |
sberyozkin
changed the title
Status for workflow
|
|
Does it actually solve the issue? I mean do we expect people will go to debug mode to figure out what's going on? Should we log it at the warn level in test/dev mode (and keep it as is for prod mode)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the endpoint is secured by a bearer access token verification mechanism then, when no token is provided, a debug log message should inform users about it.
It is already done in
quarkus-oidchere.But
quarkus-smallrye-jwtdoes not log the same message, so this PR adds it there as well.