Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use QUARKUS_FLYWAY_ACTIVE instead of QUARKUS_FLYWAY_ENABLED env in Kubernetes resources #44468

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Use QUARKUS_FLYWAY_ACTIVE instead of QUARKUS_FLYWAY_ENABLED env in Kubernetes resources #44468

merged 1 commit into from
Nov 14, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Nov 13, 2024 •
edited
Loading

Because this is a build-time configuration property, it doesn't make sense to have it added here
As suggested in #37040 (comment)

@gastaldi
Use QUARKUS_FLYWAY_ACTIVE instead of QUARKUS_FLYWAY_ENABLED env i…
ef97403 
…n Kubernetes resources

Because the original property is a build-time configuration property
@gastaldi gastaldi changed the title Remove QUARKUS_FLYWAY_ENABLED env from Kubernetes resources Use QUARKUS_FLYWAY_ACTIVE instead of QUARKUS_FLYWAY_ENABLED env in Kubernetes resources Nov 13, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 13, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ef97403.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi requested a review from geoand November 13, 2024 15:19
@geoand
Copy link
Contributor

geoand commented Nov 13, 2024

I think @iocanel added this, so I'll let him review

gsmet
gsmet approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it makes a lot more sense.

I think it used to work but I broke it with #35732 .

@gsmet gsmet merged commit 7eeb9dd into quarkusio:main Nov 14, 2024
27 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 14, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.16.4 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcruzdev mcruzdev mcruzdev approved these changes

@gsmet gsmet gsmet approved these changes

@iocanel iocanel Awaiting requested review from iocanel

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
area/flyway area/kubernetes triage/backport-3.15
Projects
None yet
Milestone
3.16.4
Development

Successfully merging this pull request may close these issues.

The flyway extension generates Kubernetes resources as if quarkus.flyway.enabled was a runtime property
4 participants
@gastaldi @geoand @gsmet @mcruzdev