Support for short and uncommon field names like set, get, and is #44457
+57
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
burl21
changed the title
|
/cc @mariofusco |
mariofusco
reviewed
Nov 13, 2024
| @@ -281,7 +281,7 @@ private Type fieldType() { | |||
| if (isPublicField()) { | |||
| return fieldInfo.type(); | |||
| } | |||
| if (methodInfo.name().startsWith("set")) { | |||
| if (methodInfo.parametersCount() == 1 && methodInfo.name().startsWith("set")) { | |||
mariofusco
reviewed
Nov 13, 2024
...ain/java/io/quarkus/resteasy/reactive/jackson/deployment/processor/JacksonCodeGenerator.java
Outdated
Show resolved
Hide resolved
mariofusco
suggested changes
Nov 13, 2024
There was a problem hiding this comment.
@burl21 Thanks a lot for this fix, I'd just prefer to keep it more confined to the "set", "get" and "is" field name it is supposed to support, so please see my suggestion.
mariofusco
approved these changes
Nov 13, 2024
gsmet
approved these changes
Nov 13, 2024
Status for workflow
|
|
Merged, thanks for your contribution. The fix will land in 3.16.4 that we will release next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #44433
Enhance handling of short field names specifically for records, ensuring correct support for fields like set, get, and is.