Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing initializing compilejava if empty #44432

Merged

Conversation

cdsap
Copy link
Contributor

@cdsap cdsap commented Nov 12, 2024

(Recreating #44410 because I messed up(Pull request that contains merge commits can not be merged))

Issue #44384 describes how the task quarkusAppPartsBuild fails in a multi-module project using gRPC with Kotlin. When initializing the project for the first time, the gRPC output has not been configured, and we are not including the compileJava source directory in the application model. This behavior has the following characteristics:

  • It does not occur on the second build execution, as the output is then present.
  • It occurs if the project applying the plugin does not have Java sources.

Because the Project Descriptor is instantiated during configuration time, we currently lack a reliable way to retrieve the expected outputs ahead of time. This PR mitigates this issue by creating a map of abstract collection tasks and destination directories. Then, in the Application Model task, if we detect that the source directories do not include "compileJava," we verify whether an output exists in the destination directory; if this condition is met, we add it as a source directory.

This PR also adds integration tests to simulate the original issue.

Copy link

quarkus-bot bot commented Nov 12, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Nov 12, 2024
@cdsap cdsap changed the title forcing initializing compilejava if empty Forcing initializing compilejava if empty Nov 12, 2024
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 12, 2024
Copy link

quarkus-bot bot commented Nov 12, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0462367.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit e2f7507 into quarkusio:main Nov 12, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 12, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 12, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.3 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus-grpc: Generate proto files from dependencies no longer works since Quarkus 3.16
4 participants