Make sure the result from QCL.getElementsWithResource(name) does not include duplicates #44352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
quarkus-bot
bot
added
the
area/devtools
geoand
reviewed
Nov 6, 2024
| * @param list2 second list | ||
| * @return resulting list | ||
| */ | ||
| private static List<ClassPathElement> unify(List<ClassPathElement> list1, List<ClassPathElement> list2) { |
There was a problem hiding this comment.
Minor nitpick: I would prefer if this method was called deduplicate
This comment has been minimized.
This comment has been minimized.
…include duplicates
aloubyansky
force-pushed
the
unique-resource-list
branch
from
e8e1551
to
70e2f17
Compare
This comment has been minimized.
This comment has been minimized.
geoand
approved these changes
Nov 7, 2024
gsmet
approved these changes
Nov 7, 2024
|
@ia3andy this will fix the issue in quarkus-roq |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
|
Should we try to backport this? It might be a bit risky given it's class loader-related? If we do, I would only do it for 3.16. |
|
I'd be fine either way. Perhaps @ia3andy would appreciate it being backported to 3.16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case when
QuarkusClassLoader.visitRuntimeResources(resourceName, visitor)visits the same classpath elements twice.