Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opentelemetry-tracing.adoc #44345

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Update opentelemetry-tracing.adoc #44345

merged 1 commit into from
Nov 6, 2024

Conversation

fhavel
Copy link
Contributor

@fhavel fhavel commented Nov 6, 2024

  • edited comment in docker-compose yaml, as Quarkus support HTTP export now
  • Fixing typo

@fhavel @gsmet
Update opentelemetry-tracing.adoc
1e68752 
* edited comment in docker-compose yaml, as Quarkus support HTTP export now
* Fixing typo
@gsmet
Copy link
Member

gsmet commented Nov 6, 2024

Thanks! I rebased and force pushed to your branch to avoid the merge commit.

@gsmet gsmet requested a review from brunobat November 6, 2024 13:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 6, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1e68752.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

brunobat
brunobat approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fhavel !

@cescoffier cescoffier merged commit 6959dfa into quarkusio:main Nov 6, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 6, 2024
@fhavel fhavel deleted the patch-1 branch November 7, 2024 05:38
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.3 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
3.16.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fhavel @gsmet @brunobat @cescoffier