-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OWASP dependency check plugin version #44343
Conversation
Do we have a way to test that this will fix the failure? |
@jmartisk Jan, I think maybe we can manually trigger the action ? The update is long overdue in any case |
We can trigger it manually, but to run it in this repo, we would have to merge it first. Could you try executing it in your repo? You'd go to https://github.com/sberyozkin/quarkus/actions/workflows/owasp-check.yml and trigger it using the "Run workflow" button that I don't see because I'm not an admin of your fork |
If it turns out to be a problem, we can just merge it and wait for the next nightly run |
@jmartisk Sure, just did it, will take awhile :-) |
@jmartisk It does not want to run it in my fork: https://github.com/sberyozkin/quarkus/actions/runs/11702263054/job/32590086209 I've run it on this PR's branch, while the action references the We can just merge and users can also try to run it locally |
I think you'd have to change/remove this line https://github.com/sberyozkin/quarkus/blob/816a3521115210ebc0552149653b97ba7ab3b477/.github/workflows/owasp-check.yml#L12 to allow it to run on your fork (so I guess you'd need to create another branch with just this change - to avoid polluting this PR... it's a bit tricky). But yeah I don't mind just merging it here too, after the regular CI finishes |
Status for workflow
|
Let me merge, and I'll trigger an action |
Sorry @jmartisk, I merged and then decided to scroll and noticed your comment, my apologies :-), the version update itself should be fine in any case, let me trigger the action |
@jmartisk @aloubyansky It worked :-), I guess the next step is to see how to wire in sbom |
@sberyozkin are you sure the plugin supports working from sbom? Or do you have a different plugin in mind? On the other hand, I found https://jeremylong.github.io/DependencyCheck/dependency-check-maven/index.html where Example 7 shows how to exclude vulnerabilities that we don't want to pollute the report, which may be useful |
Thanks @jmartisk, yeah, this one does not accept BOM AFAIK... Yeah, I'm not seeing which OWASP plugin can take SBOM as input for the CVE checks on dependencies... We may have to do exclusions, I'll have a look |
No description provided.