Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler: fix OffLoadingInvoker #44341

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Scheduler: fix OffLoadingInvoker #44341

merged 1 commit into from
Nov 6, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 6, 2024

  • ScheduledInvoker#invoke() should never return null

@mkouba
Scheduler: fix OffLoadingInvoker
81c9a0f 
- ScheduledInvoker#invoke() should never return null
@mkouba mkouba requested a review from manovotn November 6, 2024 08:53
@geoand
Copy link
Contributor

geoand commented Nov 6, 2024

Does this need to be backported?

@mkouba
Copy link
Contributor Author

mkouba commented Nov 6, 2024

Does this need to be backported?

It was only introduced in 3.16 so I'm not really sure... I mean, if there will be 3.16.2 released soon then yes, otherwise no.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 6, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 81c9a0f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba
Copy link
Contributor Author

mkouba commented Nov 6, 2024

Also this problem should not manifest as a failure. It's more like a housekeeping.

@manovotn manovotn merged commit c0efe5b into quarkusio:main Nov 6, 2024
24 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 6, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.3 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/scheduler
Projects
None yet
Milestone
3.16.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mkouba @geoand @manovotn @gsmet