Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of Json in OIDC #44339

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Remove use of Json in OIDC #44339

merged 1 commit into from
Nov 6, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Nov 6, 2024

Copy link

github-actions bot commented Nov 6, 2024

🎊 PR Preview 4865eae has been successfully built and deployed to https://quarkus-pr-main-44339-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Nov 6, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b7e58d6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Nov 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b7e58d6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 4bb81a2 into quarkusio:main Nov 6, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 6, 2024
@geoand geoand deleted the oidc-json branch November 6, 2024 09:04
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geoand, I did not realize it was slow on the builder path as well, happy to see it all replaced with the optimized reference.
FYI, the reason it is used on some OIDC public API paths is because it is also available at the JsonWebToken API level as a possible claim value, so I tried to keep it consistent...

Thanks

@geoand
Copy link
Contributor Author

geoand commented Nov 6, 2024

@sberyozkin you were absolutely right to use Json - that's what we were all doing until @gsmet found how horribly slow it is.

@gsmet gsmet modified the milestones: 3.17 - main, 3.16.3 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants