-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of Json in OIDC #44339
Remove use of Json in OIDC #44339
Conversation
Relates to: quarkusio#42748
🎊 PR Preview 4865eae has been successfully built and deployed to https://quarkus-pr-main-44339-preview.surge.sh/version/main/guides/
|
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @geoand, I did not realize it was slow on the builder path as well, happy to see it all replaced with the optimized reference.
FYI, the reason it is used on some OIDC public API paths is because it is also available at the JsonWebToken
API level as a possible claim value, so I tried to keep it consistent...
Thanks
@sberyozkin you were absolutely right to use |
Json.***
methods are crazily inefficient #42748