Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run the Gradle tests when using -DquicklyDocs and add some useful workflow tips #44329

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 5, 2024

No description provided.

Copy link

quarkus-bot bot commented Nov 5, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@gsmet gsmet requested a review from FroMage November 5, 2024 16:50
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Nov 5, 2024
alias qss="java -jar ${HOME}/git/quarkus/devtools/cli/target/quarkus-cli-999-SNAPSHOT-runner.jar"
```

Using `./mvnw` is often not practical in this case as you might want to call these aliases from a nested directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to use gum for solving that issue.

https://andresalmiray.com/gum-the-gradle-maven-wrapper/

then have alias mvn=gm which then locates ./mvnw if in root.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@brunobat
Copy link
Contributor

brunobat commented Nov 5, 2024

I tried the mvnd quick-build and seems ok, It really cuts the build time if you run it multiple times.
It requires mvnd 1.0.2+, with the previous version it will fail.

This comment has been minimized.

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice aliases, thanks!

- If using plain Maven

```sh
alias build-fast="mvn -T0.8C -e -DskipDocs -DskipTests -DskipITs -Dinvoker.skip -DskipExtensionValidation -Dskip.gradle.tests -Dtruststore.skip clean install"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • skipDocs, skipTests, skipITs, skipExtensionValidation
  • invoker.skip, truststore.skip
  • skip.gradle.tests

Yup, we got all three naming conventions, can't think of any other :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conventions are not ours. They are coming from the Maven plugins we are using (except skip.gradle.tests which is indeed not ideal).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured :(

@gsmet gsmet merged commit eb86e0e into quarkusio:main Nov 7, 2024
5 of 6 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 7, 2024
@gsmet
Copy link
Member Author

gsmet commented Nov 7, 2024

I applied all your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants