Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Caffeine to 3.1.8 #44159

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 29, 2024

Noticed while working on cache stuff.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Oct 29, 2024
Copy link

quarkus-bot bot commented Oct 29, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3b335c9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/panache/hibernate-reactive-rest-data-panache/deployment

io.quarkus.hibernate.reactive.rest.data.panache.deployment.repository.PanacheRepositoryResourcePutMethodTest.shouldUpdateComplexObject - History

  • 1 expectation failed. JSON path name doesn't match. Expected: is "updated collection" Actual: empty collection - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
JSON path name doesn't match.
Expected: is "updated collection"
  Actual: empty collection

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)

@gsmet
Copy link
Member Author

gsmet commented Oct 29, 2024

@DavideD apparently, the test above is a bit flaky. It's not related to this PR as I see it failing from time to time before that.

@gsmet gsmet requested a review from gastaldi October 29, 2024 17:39
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to the dependabot.yml as well?

@gastaldi gastaldi merged commit a6a9f85 into quarkusio:main Oct 29, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 29, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants