-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplication descriptors in PlatformImportsImpl #44147
Avoid duplication descriptors in PlatformImportsImpl #44147
Conversation
importedPlatformBoms.computeIfAbsent(groupId, g -> new ArrayList<>()); | ||
if (!importedPlatformBoms.get(groupId).contains(bomCoords)) { | ||
importedPlatformBoms.get(groupId).add(bomCoords); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting. I didn't realize Maven and Gradle are different in this way.
@cdsap if it finds the bomCoords
in the importedPlatformBoms
we could skip the rest of the code in this method (reading and processing properties). Would you mind adjusting it? Thanks!
...ojects/bootstrap/app-model/src/main/java/io/quarkus/bootstrap/model/PlatformImportsImpl.java
Show resolved
Hide resolved
722020a
to
a3ff2d3
Compare
Status for workflow
|
As we discussed in issue #44146, to use
PlatformImportsImpl
as input forGradleApplicationModelTask
, we need to prevent the duplications generated during configuration resolution. This PR addresses the duplication issue and includes a test to cover platform descriptor duplications