Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace oidc auth microsoft screenshots with generic ones #44086

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Replace oidc auth microsoft screenshots with generic ones #44086

merged 1 commit into from
Oct 24, 2024

Conversation

rghara
Copy link
Contributor

@rghara rghara commented Oct 24, 2024 •
edited by sberyozkin
Loading

Replace oidc auth microsoft screenshots with generic ones

Related to #42549

@rghara
Copy link
Contributor Author

rghara commented Oct 24, 2024

Hi @sberyozkin,
PR for replacing microsoft images.
There is also a small change in the description. It's called now "Microsoft Entra ID" instead of "Azure Active Directory".

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 24, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 12b8a8b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

sberyozkin
sberyozkin approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@sberyozkin sberyozkin merged commit 874e3fb into quarkusio:main Oct 24, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 24, 2024
@rghara rghara deleted the Issue-42549-change-microsoft-documentation-to-generic branch October 25, 2024 12:10
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
3.16.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rghara @sberyozkin @gsmet