Generating Jackson serializers for concrete classes only

[mariofusco]

Fixes #44069

/cc @gsmet

[mariofusco]

@gsmet I don't see any reason why all those tests should fail with JDK21 and I cannot reproduce any of those problems locally. Can you please simply relaunch that job? Or do you have any better explanation?

[mariofusco]

@gsmet sorry, ignore my latest comment, for some reason I cannot reproduce the problem from maven CLI but I can when launching those tests from inside the IDE. I need a bit more time to figure out what's happening.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c47d5ba.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/resteasy-reactive/rest-client/deployment

✖ io.quarkus.rest.client.reactive.stork.StorkResponseTimeLoadBalancerTest.shouldUseFasterService - History

• expected: "hello, Alice" but was: "hello, I'm a slow server" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "hello, Alice"
 but was: "hello, I'm a slow server"
	at io.quarkus.rest.client.reactive.stork.StorkResponseTimeLoadBalancerTest.shouldUseFasterService(StorkResponseTimeLoadBalancerTest.java:58)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)

[gsmet]

@mariofusco out of curiosity, what was the issue?

[mariofusco]

@gsmet it should be ok now. The problem is that it was uselessly trying to generate serializers also for not concrete classes (abstract classes or interfaces) and moreover trying to register them into the Jackson ObjectMapper caused an error internally to Jackson during serialization.

[gsmet]

That part I understood :). I was more wondering what caused a specific Java 21 failure :)

[mariofusco]

That part I understood :). I was more wondering what caused a specific Java 21 failure :)

Sorry I misunderstood your question :)

Actually it was a real bug in my yesterday's commit. It is true that I don't want to generate serializers for abstract classes, but with what I did yesterday it was skipping in the generated serializers for a concrete class the fields eventually inherited from its abstract parent. To be honest I have no clue why this failed only on Java 21.

[gsmet]

OK, thanks!