Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undertow: ignore missing servlet class in web.xml #44063

Merged

Conversation

rodcheater
Copy link
Contributor

Avoids writing a null bean name to the bean archive, which causes a later build failure.

Fixes #43825

Avoids writing a null bean name to the bean archive, which causes a
later build failure.

Fixes quarkusio#43825
@rodcheater rodcheater force-pushed the 43825-ignore-missing-servlet-class-in-web-xml branch from eb01531 to df4696b Compare October 24, 2024 05:11
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link

quarkus-bot bot commented Oct 24, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit df4696b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet
Copy link
Member

gsmet commented Oct 24, 2024

@geoand given you suggested the change, I let you have a look at it before merging!

@geoand
Copy link
Contributor

geoand commented Oct 24, 2024

I did? I have no recollection of that

@gsmet
Copy link
Member

gsmet commented Oct 24, 2024

Ah sorry, it was @mkouba :).

@gsmet gsmet merged commit ae7c297 into quarkusio:main Oct 24, 2024
48 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 24, 2024
@gsmet
Copy link
Member

gsmet commented Oct 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BeanArchiveProcessor#build threw an exception: Local name must not be null
4 participants