Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace oidc authentication for github screenshots with generic ones #44029

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Replace oidc authentication for github screenshots with generic ones #44029

merged 1 commit into from
Oct 22, 2024

Conversation

rghara
Copy link
Contributor

@rghara rghara commented Oct 22, 2024 •
edited by sberyozkin
Loading

Replaces oidc authentication for github screenshots with generic ones.

Related to #42549

@rghara rghara mentioned this pull request Oct 22, 2024
Closed
@sberyozkin sberyozkin changed the title Fix for issue 42549 - replaces oidc authentication for github screenshots with generic ones Replace oidc authentication for github screenshots with generic ones Oct 22, 2024
@sberyozkin sberyozkin self-requested a review October 22, 2024 22:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 156754c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

sberyozkin
sberyozkin approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've only updated the PR description as the linked issue will need a few more PRs...

@sberyozkin sberyozkin merged commit b92fa13 into quarkusio:main Oct 22, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 22, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rghara @sberyozkin @gsmet