Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump org.htmlunit to 4.5.0 #44017

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Bump org.htmlunit to 4.5.0 #44017

merged 1 commit into from
Oct 23, 2024

Conversation

mcruzdev
Copy link
Contributor

With some issues on #43986 pull request.

I decided to create this one to solve that.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Oct 22, 2024
@mcruzdev mcruzdev mentioned this pull request Oct 22, 2024
Closed
gsmet
gsmet approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's see what CI has to say.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 22, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 22, 2024 •
edited
Loading

Thanks! Let's see what CI has to say.

CI said there are two methods with the same name haha, that need to be solved!

@mcruzdev
Copy link
Contributor Author

Now it is ok! @gsmet

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6867fc3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 539705f into quarkusio:main Oct 23, 2024
52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 23, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 23, 2024
@gsmet
Copy link
Member

gsmet commented Oct 23, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Milestone
3.17.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@mcruzdev @gsmet