-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure we have Agroal datasources before configuring health checks #43991
Conversation
@michalvavrik I tried to add a test to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I find it odd that the bean would not be resolvable... I suspect the bean having the default scope (dependent), toghether with the use of bytecode recorders, might have something to do with that, so I sent a suggestion to your fork: gsmet#193
Make it a singleton, initialize it on runtime init.
I tried, but inside Argoal deployment module you have a JDBC extension (H2) so I think you won't reproduce it there. If you drop it you can reproduce it like this 84813f9. So unless you have different module I don't think you can reproduce it. |
OK, I think we will have to live with it then. @michalvavrik if you can independently verify the last version of this PR fixes it for you, that would be awesome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the latest version and it fixes my issue. Thank you
Status for workflow
|
Fixes #43990