-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR for managing native libraries in GraalVM native images #43984
ADR for managing native libraries in GraalVM native images #43984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the write down @cescoffier! It looks good to me. Just added a few comments that I leave up to you to decide if they are worth including or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! good to have written down.
just minor suggestions on clarification but otherwise +1
Just realized - should we document pattern to use for when libraries have all binaries included in one artifacts vs using multiple classifers (multiple artifacts) ? |
I don't think we use any different pattern in this case (at least in native mode). |
I've added a note. |
This commit introduces an ADR detailing the process for managing native libraries in Quarkus extensions when performing native compilation with GraalVM. Key points include: - Using GraalVM's `Feature` mechanism to select and include platform-specific native libraries. - Centralizing native library management and runtime initialization configuration within the `Feature`. - Examples for implementing a `Feature` to include native libraries such as `brotli.so`. - Discussion of considered options and consequences of using the `Feature` approach. Co-authored-by: @zakkak
b6535c3
to
af6a5e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the additions.
Comments have been addressed AFAICS. Let's merge!
AFAICS, Max was +1 and his comments were addressed so let's merge! |
This PR introduces an ADR detailing the process for managing native libraries in Quarkus extensions when performing native compilation with GraalVM.
Key points include:
Feature
mechanism to select and include platform-specific native libraries.Feature
.Feature
to include native libraries such asbrotli.so
.Feature
approach.