Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip logging invalid recipients when sending emails #43955

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

cescoffier
Copy link
Member

This commits detects and prevents logging invalid recipients before delegating to the underlying SMTP client, avoiding the overhead of processing attachments for emails that won’t be sent as well as acquiring an unnecessary connection.

When the option is enabled (default), the invalid recipients is not logged and not part of the thrown exception.

This commits detects and prevents logging invalid recipients before delegating to the underlying SMTP client, avoiding the overhead of processing attachments for emails that won’t be sent as well as acquiring an unnecessary connection.

When the option is enabled (default), the invalid recipients is not logged and not part of the thrown exception.
Copy link

quarkus-bot bot commented Oct 18, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fa28a69.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

🎊 PR Preview 3cfbfcb has been successfully built and deployed to https://quarkus-pr-main-43955-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Oct 18, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fa28a69.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question: the lower layer will never log a message with the email if something bad happens when sending the email? I.e. unable to connect to the server, or any other technical issue that could happen?

@cescoffier
Copy link
Member Author

cescoffier commented Oct 18, 2024

No, if there is an invalid email, it will not be called.

Otherwise, it does not print the email address.

@gsmet gsmet merged commit 744bc75 into quarkusio:main Oct 19, 2024
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 19, 2024
@cescoffier cescoffier deleted the mailer-no-log-invalid-recipient branch October 21, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants