-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for single same uri redirects for OIDC WebClient #43938
Support for single same uri redirects for OIDC WebClient #43938
Conversation
e83a4e4
to
65f1fb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you think we should document this feature?
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@cescoffier Thanks, sure, will have a look |
Hi @cescoffier, I've started documenting it, and thought, may be we should do it when, at some point, the same is supported at the WebClient level, otherwise I'm not sure how to say in the docs: if you'd like to have a same URI redirect supported you must disable auto-following redirects, which does not read very logical :-). I can still do it though if you prefer. |
@cescoffier Let me actually add a few lines |
65f1fb7
to
5bbcc83
Compare
@cescoffier Docs updated, that should be better now |
Status for workflow
|
Status for workflow
|
Fixes #43937.
This PR enables a single time redirect support when one of GET OidcProvider endpoints (discovery, JWK, or UserInfo) request a redirect exactly to the same URI, as long as one or more cookies are available during such redirect.
it is impossible to avoid adding a property in this case. Some users may already depending on the auto-redirect feature without cookies.