-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify tech preview status of OTel logs and metrics in docs #43930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but maybe add ::extension-status: preview
so the usual preview banner gets added?
The issue is that the extension includes Otel Tracing which is supported... It is the logging and metrics part that is tech preview... We chose to have them off by default. |
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @brunobat, LGTM, I just had a minor comment.
Just to clarify for the RHBQ docs, we don't make reference to OpenTelemetry Logging in 3.15 release notes Tech Preview updates; only reference the OTel metrics.
14dbbc8
to
8c974b5
Compare
8c974b5
to
5e91ce6
Compare
yes, but is this doc not specifically about metrics? that macro/parameter just makes it very clear the content of this doc is preview. |
This comment has been minimized.
This comment has been minimized.
umm... good point. Will add that to the logging and metrics guides. |
5e91ce6
to
150a87e
Compare
This comment has been minimized.
This comment has been minimized.
150a87e
to
e89351d
Compare
Some parts of the docs were outdated. Should be fixed now. |
e89351d
to
fb3a997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Status for workflow
|
No description provided.