Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify tech preview status of OTel logs and metrics in docs #43930

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

brunobat
Copy link
Contributor

No description provided.

Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but maybe add ::extension-status: preview so the usual preview banner gets added?

@brunobat
Copy link
Contributor Author

brunobat commented Oct 17, 2024

looks good but maybe add ::extension-status: preview so the usual preview banner gets added?

The issue is that the extension includes Otel Tracing which is supported... It is the logging and metrics part that is tech preview... We chose to have them off by default.
This was discussed with @tqvarnst

Copy link

github-actions bot commented Oct 17, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Contributor

@sheilamjones sheilamjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brunobat, LGTM, I just had a minor comment.
Just to clarify for the RHBQ docs, we don't make reference to OpenTelemetry Logging in 3.15 release notes Tech Preview updates; only reference the OTel metrics.

docs/src/main/asciidoc/opentelemetry-logging.adoc Outdated Show resolved Hide resolved
@maxandersen
Copy link
Member

The issue is that the extension includes Otel Tracing which is supported... It is the logging and metrics part that is tech preview... We chose to have them off by default.
This was discussed with @tqvarnst

yes, but is this doc not specifically about metrics? that macro/parameter just makes it very clear the content of this doc is preview.

This comment has been minimized.

@brunobat
Copy link
Contributor Author

The issue is that the extension includes Otel Tracing which is supported... It is the logging and metrics part that is tech preview... We chose to have them off by default.
This was discussed with @tqvarnst

yes, but is this doc not specifically about metrics? that macro/parameter just makes it very clear the content of this doc is preview.

umm... good point. Will add that to the logging and metrics guides.

This comment has been minimized.

@brunobat
Copy link
Contributor Author

Some parts of the docs were outdated. Should be fixed now.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 25, 2024
Copy link

quarkus-bot bot commented Oct 25, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fb3a997.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit e6dd03e into quarkusio:main Oct 25, 2024
5 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 25, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 25, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants