Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC: register synthetic injection points in a separate phase #43898

Merged
merged 1 commit into from
Oct 16, 2024
Merged

ArC: register synthetic injection points in a separate phase #43898

merged 1 commit into from
Oct 16, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 16, 2024

  • this fixes the problem where an synthetic injection point from a SyntheticBeanBuiltItem was not considered when detecting unused beans

Thanks for reporting the problem @michalvavrik!

@mkouba
ArC: register synthetic injection points in a separate phase
03ca632 
- this fixes the problem where an synthetic injection point from a
SyntheticBeanBuiltItem was not considered when detecting unused beans
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Oct 16, 2024
Ladicek
Ladicek approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to understand why/how this works, but LGTM!

@mkouba
Copy link
Contributor Author

mkouba commented Oct 16, 2024

Took me a while to understand why/how this works, but LGTM!

Took me a while to find where the problem is... ;-)

manovotn
manovotn approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find and good fix 👍

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 16, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 16, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 03ca632.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@manovotn manovotn merged commit 32c08ba into quarkusio:main Oct 16, 2024
52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 16, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 16, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.0 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mkouba @Ladicek @manovotn @gsmet