-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support @Decorated bean injection in decorator #43864
Conversation
rmanibus
commented
Oct 14, 2024
•
edited by geoand
Loading
edited by geoand
- Fixes: Quarkus does not support injecting @Decorated in decorator #43863
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
d4a3780
to
2689132
Compare
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BuiltinBean.java
Outdated
Show resolved
Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BuiltinBean.java
Outdated
Show resolved
Hide resolved
independent-projects/vertx-utils/src/main/java/io/quarkus/vertx/utils/VertxOutputStream.java
Outdated
Show resolved
Hide resolved
Some validations are missing, but otherwise LGTM on the first sight. |
5cdb402
to
29df899
Compare
This comment has been minimized.
This comment has been minimized.
I think I fixed everything. The build should pass now. I also added some doc |
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BuiltinBean.java
Outdated
Show resolved
Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BuiltinBean.java
Outdated
Show resolved
Hide resolved
As mentioned above, some validations are missing. I implemented them in this branch: https://github.com/Ladicek/quarkus/commits/arc-decorated-validations/ Your commit from this PR is unchanged, I added a second commit on top of that. |
...nt-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/DecoratedBeanMetadataProvider.java
Outdated
Show resolved
Hide resolved
...s/arc/tests/src/test/java/io/quarkus/arc/test/decorators/decorated/InvalidDecoratedTest.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you pls squash the commits?
.../arc/runtime/src/main/java/io/quarkus/arc/impl/InterceptedDecoratedBeanMetadataProvider.java
Outdated
Show resolved
Hide resolved
@mkouba sure thing, it's done ! |
Status for workflow
|
Status for workflow
|
@rmanibus Thanks for your contribution! |