Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support @Decorated bean injection in decorator #43864

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

rmanibus
Copy link
Contributor

@rmanibus rmanibus commented Oct 14, 2024

Copy link

quarkus-bot bot commented Oct 14, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Oct 14, 2024
@rmanibus
Copy link
Contributor Author

cc @mkouba , @Ladicek

@rmanibus rmanibus force-pushed the fix_43863 branch 3 times, most recently from d4a3780 to 2689132 Compare October 14, 2024 15:30
@Ladicek
Copy link
Contributor

Ladicek commented Oct 14, 2024

Some validations are missing, but otherwise LGTM on the first sight.

This comment has been minimized.

@rmanibus
Copy link
Contributor Author

rmanibus commented Oct 14, 2024

I think I fixed everything. The build should pass now. I also added some doc

This comment has been minimized.

Copy link

github-actions bot commented Oct 14, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@Ladicek
Copy link
Contributor

Ladicek commented Oct 15, 2024

As mentioned above, some validations are missing. I implemented them in this branch: https://github.com/Ladicek/quarkus/commits/arc-decorated-validations/ Your commit from this PR is unchanged, I added a second commit on top of that.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@geoand geoand requested a review from mkouba October 16, 2024 10:21
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls squash the commits?

@rmanibus
Copy link
Contributor Author

@mkouba sure thing, it's done !

Copy link

quarkus-bot bot commented Oct 16, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 36c636c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Oct 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 36c636c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/mongodb-panache

io.quarkus.it.mongodb.panache.ReflectionFreeSerializationTest.testReactiveBookEntity - History

  • com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input at [Source: REDACTED (\StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]-java.lang.RuntimeException`
java.lang.RuntimeException: 
com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]
	at io.restassured.internal.path.json.mapping.JsonPathJackson2ObjectDeserializer.deserialize(JsonPathJackson2ObjectDeserializer.java:30)
	at io.restassured.path.json.mapping.JsonPathObjectDeserializer$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.Jackson2Mapper.deserialize(Jackson2Mapper.groovy:58)
	at io.restassured.mapper.ObjectMapper$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.ObjectMapping.parseWithJackson2(ObjectMapping.groovy:254)

⚙️ JVM Tests - JDK 21

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - History

  • INTERNAL: Half-closed without a request - io.grpc.StatusRuntimeException
io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.Status.asRuntimeException(Status.java:533)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:631)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testStreamingOutputCall(VirtualThreadTestBase.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:971)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:821)

@mkouba mkouba merged commit a1ef891 into quarkusio:main Oct 17, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 17, 2024
@mkouba
Copy link
Contributor

mkouba commented Oct 17, 2024

@rmanibus Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus does not support injecting @Decorated in decorator
4 participants