-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rocksdb native library resource registration to a feature #43782
Conversation
@rsvoboda I am trying to get access to an AArch64 machine to give this a go, but it takes much longer than expected. So if you have a setup you can easily use to confirm the PR resolves the issue please let me know. Thanks |
This comment has been minimized.
This comment has been minimized.
@zakkak I can look into it, provisioning machine from Beaker usually takes ~1 hour, so I will have to wait too ... |
...treams/runtime/src/main/java/io/quarkus/kafka/streams/runtime/graal/KafkaStreamsFeature.java
Outdated
Show resolved
Hide resolved
That's indeed very clever. I will probably use this pattern elsewhere as it makes a lot of sense. |
...eams/deployment/src/main/java/io/quarkus/kafka/streams/deployment/KafkaStreamsProcessor.java
Outdated
Show resolved
Hide resolved
I've checked the reproducer and the app is working well on RHEL8 aarch64 |
Always registers the correct native library as the logic runs on the same architecture we are targeting (even when using containers). Closes quarkusio#43319
ad1d063
to
53d2635
Compare
Great, thanks for the review and the testing @rsvoboda. I addressed both your comments. |
Status for workflow
|
Probably at some point. I will add the label. |
Always registers the correct native library as the logic runs on the same architecture we are targeting (even when using containers). Related to quarkusio#43782
Always registers the correct native library as the logic runs on the same architecture we are targeting (even when using containers). Related to quarkusio#43782
Always registers the correct native library as the logic runs on the same architecture we are targeting (even when using containers). Related to quarkusio#43782
Always registers the correct native library as the logic runs on the same architecture we are targeting (even when using containers).
Closes #43319